CVS-154703, Implement createTempPath(std::string* local_path) for windows #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasapala
changed the title
|
Enable those unit tests for the change: "test/localfilesystem_test.cpp", |
…nt test/localfilesystem_test.cpp unit test
18582088138
changed the title
rasapala
reviewed
Jan 9, 2025
src/filesystem.hpp
Outdated
|
|
||
| DWORD path_len = GetTempPathW(MAX_PATH, temp_path); | ||
| if (path_len == 0 || path_len > MAX_PATH) { | ||
| SPDLOG_LOGGER_ERROR(modelmanager_logger, "Failed to get temp path: {}", GetLastError()); |
There was a problem hiding this comment.
Add logging error message:
DWORD error = GetLastError();
std::string message = std::system_category().message(error);
There was a problem hiding this comment.
Please add message to log in all LastError cases.
rasapala
reviewed
Jan 9, 2025
src/filesystem.hpp
Outdated
| #elif _WIN32 | ||
| static StatusCode createTempPath(std::string* local_path) { | ||
| if (!local_path) | ||
| return StatusCode::FILESYSTEM_ERROR; |
There was a problem hiding this comment.
Lets add log here that target temp path is not set: SPDLOG_LOGGER_ERROR(modelmanager_logger, "Target path variable for createTempPAth not set. {}"
There was a problem hiding this comment.
following the commit and the modify the code
rasapala
reviewed
Jan 9, 2025
| } | ||
| #elif _WIN32 | ||
| static StatusCode createTempPath(std::string* local_path) { | ||
| if (!local_path) |
There was a problem hiding this comment.
The error path should be in { } for the local_path check
dkalinowski
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Implement createTempPath(std::string* local_path) for windows
JIRA/Issue: CVS-154703
🧪 Checklist
``