-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic media support #539
Conversation
@zhiltsov-max, I think PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now these approaches are not alternative, because if user using video_frames
format it's not possible to export such dataset in other Image
media type format. I think we should to mention it in docs or allow VideoFrame
media type for Image
formats.
@kirill-sizov, VideoFrame is subclass of Image, so it should be working. |
@zhiltsov-max, I meant that for example such code throws an error: from datumaro.components.dataset import Dataset
dataset = Dataset.import_from('video.mp4', format='video_frames')
dataset.export('./save_dir', 'voc', save_media=True)
|
Summary
Depends on #538
Related #675
DatasetItem.media
to replace dedicated members for each media typePointCloud
media typemedia_type()
method toExtractor
smedia_type()
methodmedia_type
argument toDataset.from_iterable
. It has a default value ofImage
for the transition period (to be tracked in Support different media types #675).DatasetItem.image
,.related_images
,.point_cloud
,save-images
andrequire_images
components.extractor
TODO:
--save-media
in CLI[ ] Media type deduction by path (do we need it at all?)How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.