Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Remove Upper Bound on wandb Dependency #2322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐞 Remove Upper Bound on wandb Dependency #2322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b9c016
Remove wandb upper bound
samet-akcay Sep 25, 2024
7a53e7e
Ignore cs-flow tests for openvino export
samet-akcay Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ loggers = [
"comet-ml>=3.31.7",
"gradio>=4",
"tensorboard",
"wandb>=0.12.17,<=0.15.9",
"wandb>=0.12.17",
"mlflow >=1.0.0",
]
notebooks = ["gitpython", "ipykernel", "ipywidgets", "notebook"]
Expand Down
5 changes: 5 additions & 0 deletions tests/integration/model/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ def test_export(
# https://github.com/openvinotoolkit/anomalib/issues/1513
pytest.skip(f"{model_name} fails to convert to OpenVINO")

# TODO(samet-akcay, ashwinvaidya17): Fix this test after fixing the issue
# https://github.com/openvinotoolkit/anomalib/issues/2047
if model_name == "cs_flow" and export_type == ExportType.OPENVINO:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the logs, it looks like that the torch JIT fails. Probably wandb is changing some hook. Either case, I think skipping the torch export rather than openvino might make the test pass. However, I am not sure if onnx export is affected as well.

pytest.skip(f"{model_name} is not supported for OpenVINO export")

model, dataset, engine = self._get_objects(
model_name=model_name,
dataset_path=dataset_path,
Expand Down
Loading