Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to download Transmodel GraphQL Schema #6330

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Dec 10, 2024

Summary

This PR add a read-only endpoint (HTTP GET) for fetching the Transmodel GraphQL Schema. The schema can be fetched today using the GraphQL introspection, but this is a bit technical and the result need to be translated into SDL (if needed).

We will use this to generate the input controls for the trip search in the OTP Debug UI. It can also be used for "human introspection".

Issue

🟥 No issue, but this is part of making a generic input control for the Debug UI.

Unit tests

🟥 This is just one line of code with logic - only using library code. The schema is for

Documentation

✅ The usage is documented with a comment included at the top of the schema file.
🟥 The endpoint is not documented outside the code - this should be sufficient since it is not intended
for production/integration - only for the convenience of developers.

Changelog

🟥 Not a production feature or relevant for Product Owners

Bumping the serialization version id

🟥 Not needed

@t2gran t2gran added Improvement Entur Test This is currently being tested at Entur Skip Changelog labels Dec 10, 2024
@t2gran t2gran added this to the 2.7 (next release) milestone Dec 10, 2024
@t2gran t2gran requested a review from a team as a code owner December 10, 2024 12:36
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.81%. Comparing base (e0422cd) to head (f765199).
Report is 33 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...opentripplanner/apis/transmodel/TransmodelAPI.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6330      +/-   ##
=============================================
+ Coverage      69.79%   69.81%   +0.01%     
- Complexity     17797    17823      +26     
=============================================
  Files           2019     2020       +1     
  Lines          76119    76269     +150     
  Branches        7786     7806      +20     
=============================================
+ Hits           53129    53246     +117     
- Misses         20284    20306      +22     
- Partials        2706     2717      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eibakke eibakke self-requested a review December 11, 2024 07:22
@t2gran t2gran merged commit cd254bf into opentripplanner:dev-2.x Dec 11, 2024
5 checks passed
@t2gran t2gran deleted the otp2_add_schema_endpoint branch December 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entur Test This is currently being tested at Entur Improvement Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants