-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitransit ext config #6323
Closed
tkalvas
wants to merge
88
commits into
opentripplanner:dev-2.x
from
HSLdevcom:digitransit_ext_config
Closed
Digitransit ext config #6323
tkalvas
wants to merge
88
commits into
opentripplanner:dev-2.x
from
HSLdevcom:digitransit_ext_config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DT-4561 Add search by ids to bike rental stations graphql query
Fix default value for capacity
This reverts commit 7fe77ac.
…g, as currently github gives repo name as 'HSLdevcom/OpenTripPlanner'
DT-6018: Update actions
Minor code and data cleanup
…f invalid tagging
DT-6317 Run tests before docker push and use jib as a docker build tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Instructions
When creating a pull request, please follow the format below. For each section, replace the
guidance text with your own text, keeping the section heading. If you have nothing to say in a
particular section, you can completely delete the section including its heading to indicate that you
have taken the requested steps. None of these instructions or the guidance text (non-heading text)
should be present in the submitted PR. These sections serve as a checklist: when you have replaced
or deleted all of them, the PR is considered complete. As of 2021, most regular OTP contributors
participate in our twice-weekly conference calls. For all but the simplest and smallest PRs,
participation in these discussions is necessary to facilitate the review and merge process. Other
developers can ask questions and provide immediate feedback on technical design and code style, and
resolve any concerns about long term maintenance and comprehension of new code.
Summary
Explain in one or two sentences what this PR achieves.
Issue
Link to or create an issue that
describes the relevant feature or bug. You need not create an issue for small bugfixes and code
cleanups, but in that case do describe the problem clearly and completely in the "summary" section
above. In the linked issue (or summary section for smaller PRs) please describe:
Remember that the PR will be reviewed by another developer who may not be familiar with your use
cases or the code you're modifying. It generally takes much less effort for the author of a PR to
explain the background and technical details than for a reviewer to infer or deduce them. PRs may be
closed if they or their linked issues do not contain sufficient information for a reviewer to
proceed.
Add GitHub keywords to this PR's
description, for example:
Closes #45
Unit tests
Write a few words on how the new code is tested.
pass the continuous integration service
?
Documentation
the configuration documentation updated?
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add the label
skip changelog
to the PR.Bumping the serialization version id
If you have made changes to the way the routing graph is serialized, for example by renaming a field
in one of the edges, then you must add the label
bump serialization id
to the PR. With this labelGithub Actions will increase the field
otp.serialization.version.id
inpom.xml
.