Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitransit ext config #6323

Closed

Conversation

tkalvas
Copy link
Contributor

@tkalvas tkalvas commented Dec 9, 2024

PR Instructions

When creating a pull request, please follow the format below. For each section, replace the
guidance text with your own text, keeping the section heading. If you have nothing to say in a
particular section, you can completely delete the section including its heading to indicate that you
have taken the requested steps. None of these instructions or the guidance text (non-heading text)
should be present in the submitted PR. These sections serve as a checklist: when you have replaced
or deleted all of them, the PR is considered complete. As of 2021, most regular OTP contributors
participate in our twice-weekly conference calls. For all but the simplest and smallest PRs,
participation in these discussions is necessary to facilitate the review and merge process. Other
developers can ask questions and provide immediate feedback on technical design and code style, and
resolve any concerns about long term maintenance and comprehension of new code.

Summary

Explain in one or two sentences what this PR achieves.

Issue

Link to or create an issue that
describes the relevant feature or bug. You need not create an issue for small bugfixes and code
cleanups, but in that case do describe the problem clearly and completely in the "summary" section
above. In the linked issue (or summary section for smaller PRs) please describe:

  • Motivation (problem or need encountered)
  • How the code works
  • Technical approach and any design considerations or decisions

Remember that the PR will be reviewed by another developer who may not be familiar with your use
cases or the code you're modifying. It generally takes much less effort for the author of a PR to
explain the background and technical details than for a reviewer to infer or deduce them. PRs may be
closed if they or their linked issues do not contain sufficient information for a reviewer to
proceed.

Add GitHub keywords to this PR's
description, for example:

Closes #45

Unit tests

Write a few words on how the new code is tested.

  • Were unit tests added/updated?
  • Was any manual verification done?
  • Any observations on changes to performance?
  • Was the code designed so it is unit testable?
  • Were any tests applied to the smallest appropriate unit?
  • Do all tests
    pass the continuous integration service
    ?

Documentation

  • Have you added documentation in code covering design and rationale behind the code?
  • Were all non-trivial public classes and methods documented with Javadoc?
  • Were any new configuration options added? If so were the tables in
    the configuration documentation updated?

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add the label skip changelog to the PR.

Bumping the serialization version id

If you have made changes to the way the routing graph is serialized, for example by renaming a field
in one of the edges, then you must add the label bump serialization id to the PR. With this label
Github Actions will increase the field otp.serialization.version.id in pom.xml.

optionsome and others added 30 commits September 21, 2020 14:51
DT-4561 Add search by ids to bike rental stations graphql query
Fix default value for capacity
vesameskanen and others added 28 commits June 14, 2022 11:17
…g, as currently github gives repo name as 'HSLdevcom/OpenTripPlanner'
DT-6317 Run tests before docker push and use jib as a docker build tool
@tkalvas tkalvas requested a review from a team as a code owner December 9, 2024 13:20
@tkalvas tkalvas closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does OTP Deployment look like?
4 participants