Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to the shaded jar for performance tests and in doc #6310

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Dec 6, 2024

Summary

Fix the broken performance test and a few references to the shaded jar in in doc.

Issue

πŸŸ₯ No issue for this.

Unit tests

πŸŸ₯ Not relevant.

Documentation

βœ… Updated.

Changelog

πŸŸ₯ Not relevant.

Bumping the serialization version id

πŸŸ₯ Not relevant.

@t2gran t2gran added this to the 2.7 (next release) milestone Dec 6, 2024
@t2gran t2gran requested a review from a team as a code owner December 6, 2024 09:11
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 69.79%. Comparing base (0ce1067) to head (3952cfc).
Report is 3 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6310   +/-   ##
==========================================
  Coverage      69.79%   69.79%           
  Complexity     17785    17785           
==========================================
  Files           2017     2017           
  Lines          76035    76035           
  Branches        7781     7781           
==========================================
  Hits           53070    53070           
  Misses         20260    20260           
  Partials        2705     2705           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@leonardehrenfried
Copy link
Member

I'm happy for you to use your admin priviledges to merge it without a second reviewer.

@leonardehrenfried
Copy link
Member

I noticed another problem: the shaded jar is no longer published to the Maven repo because the packaging of shaded-jar is pom.

This is used for publishing the shaded jar to Maven Central but also for myself when I download the latest snapshot from Github. Let's decide in the dev meeting if any of these things are worth having.

@t2gran t2gran changed the title fix: Fix references to the shaded jar for performance tests and in doc Fix references to the shaded jar for performance tests and in doc Dec 6, 2024
@t2gran t2gran merged commit 0efdb4f into opentripplanner:dev-2.x Dec 7, 2024
5 checks passed
@t2gran t2gran deleted the fix_shaded_jar_ref branch December 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants