Detect JSON array in addition to JSON objects when including a file in the config. #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6307 +/- ##
=============================================
+ Coverage 69.79% 69.81% +0.01%
- Complexity 17798 17824 +26
=============================================
Files 2019 2019
Lines 76126 76244 +118
Branches 7786 7802 +16
=============================================
+ Hits 53132 53228 +96
- Misses 20288 20302 +14
- Partials 2706 2714 +8 ☔ View full report in Codecov by Sentry. |
...src/main/java/org/opentripplanner/standalone/config/framework/file/IncludeFileDirective.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
requested changes
Dec 9, 2024
habrahamsson-skanetrafiken
previously approved these changes
Dec 11, 2024
miklcct
requested review from
leonardehrenfried and
habrahamsson-skanetrafiken
leonardehrenfried
approved these changes
Dec 12, 2024
habrahamsson-skanetrafiken
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This detects
[]in addition to{}when including JSON in config files.Issue
Fixes #6305
Unit tests
Added for JSON array in addition for JSON object
Documentation
Updated
Changelog
Bumping the serialization version id
Not needed