Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GTFS flex safe_duration_offset back to seconds #6298

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

leonardehrenfried
Copy link
Member

Summary

There has been a bit of unfortunate back-and-forth when writing the spec draft for the GTFS flex duration extension. We agreed that we want to switch the field safe_duration_offset to mean seconds as other duration in the spec also us this unit.

Issue

MobilityData/gtfs-flex#79

Unit tests

Updated.

Documentation

No.

@leonardehrenfried leonardehrenfried added Improvement GTFS Related to import of GTFS data labels Dec 3, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner December 3, 2024 07:26
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (c7fe2f2) to head (7aea107).
Report is 26 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6298      +/-   ##
=============================================
- Coverage      69.79%   69.79%   -0.01%     
+ Complexity     17790    17787       -3     
=============================================
  Files           2017     2017              
  Lines          76042    76042              
  Branches        7781     7781              
=============================================
- Hits           53077    53076       -1     
  Misses         20263    20263              
- Partials        2702     2703       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit 684b841 into opentripplanner:dev-2.x Dec 4, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Dec 4, 2024
@leonardehrenfried leonardehrenfried deleted the flex-duration branch December 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Related to import of GTFS data Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants