Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fare service from Graph #6292

Open
wants to merge 8 commits into
base: dev-2.x
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Member

Summary

This removes the fare service from the Graph instance and lets Dagger manage it instead.

Unit tests

A few unit tests had to be adjusted.

Bumping the serialization version id

✔️

@leonardehrenfried leonardehrenfried added Technical Debt bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog labels Nov 29, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 29, 2024 11:00
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.81%. Comparing base (e15f69b) to head (0a49291).

Files with missing lines Patch % Lines
...n/java/org/opentripplanner/standalone/OTPMain.java 0.00% 2 Missing ⚠️
...entripplanner/apis/gtfs/GraphQLRequestContext.java 0.00% 1 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java 0.00% 1 Missing ⚠️
...pplanner/standalone/configure/LoadApplication.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6292      +/-   ##
=============================================
- Coverage      69.82%   69.81%   -0.01%     
+ Complexity     17827    17823       -4     
=============================================
  Files           2020     2020              
  Lines          76269    76269              
  Branches        7806     7806              
=============================================
- Hits           53253    53248       -5     
- Misses         20301    20305       +4     
- Partials        2715     2716       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken marked this pull request as draft December 10, 2024 10:34
@leonardehrenfried leonardehrenfried marked this pull request as ready for review December 19, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant