Create OTP utils module for basic utility features #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this in a separate PR from moving the files to keep git-history.
t2gran
added
Technical Debt
bump serialization id
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6209 +/- ##
=============================================
- Coverage 69.94% 69.92% -0.02%
+ Complexity 17743 17729 -14
=============================================
Files 1998 2000 +2
Lines 75464 75487 +23
Branches 7723 7727 +4
=============================================
+ Hits 52784 52787 +3
- Misses 20009 20015 +6
- Partials 2671 2685 +14 ☔ View full report in Codecov by Sentry. |
| import java.util.HashSet; | ||
| import java.util.Set; | ||
|
|
||
| public class ToveUtils { |
There was a problem hiding this comment.
Suggested change
| public class ToveUtils { | |
| public class TroveUtils { |
leonardehrenfried
requested changes
Nov 4, 2024
There was a problem hiding this comment.
ToveUtils should be TroveUtils.
The coverage goes down with this because the reports are not aggregated but I'm hoping to fix it with the following PR: #6220
eibakke
previously approved these changes
Nov 4, 2024
leonardehrenfried
approved these changes
Nov 4, 2024
eibakke
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR create another maven module and move "true" utilities into it. The new Maven module make is possible to split the application in other modules, like Raptor, OTP domain, street and so on.
The utilities should have no dependencies to other parts of OTP and no dependencies to other 3rd party libraries - except the @nullable annotation lib.
Issue
Part of #6155
Unit tests
This is a pure restructuring of the code. One test is removed, since the method tested was unused, and removed.
Documentation
No do is changed.
Changelog
This can skip the change log.
Bumping the serialization version id
Unsure if changing the package name for the utility classes have any thing to say, but some of the utility classes is serialized, so we bump the version id to be safe.