Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relay connection and global object identification specification guidelines to decision records #6193

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Oct 24, 2024

Summary

Replace #6080

Add a page for best practices for API Design and add a guideline for relay connection specification and for using global object identification specification.

Issue

This was discussed in the developer meeting on 19. Sep 2024

Unit tests

🟥 Not relevant

Documentation

✅ Add developer doc

Changelog

🟥 Not relevant

Bumping the serialization version id

🟥 Not relevant

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 24, 2024
@t2gran t2gran requested a review from a team as a code owner October 24, 2024 11:53
@optionsome optionsome marked this pull request as draft October 24, 2024 14:41
@optionsome optionsome marked this pull request as ready for review December 9, 2024 10:06
@optionsome optionsome changed the title Add relay connection specification guidelines to decision records Add relay connection and global object identification specification guidelines to decision records Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (c550e29) to head (2e7720f).
Report is 52 commits behind head on dev-2.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6193   +/-   ##
==========================================
  Coverage      69.79%   69.79%           
- Complexity     17797    17798    +1     
==========================================
  Files           2019     2019           
  Lines          76119    76119           
  Branches        7786     7786           
==========================================
  Hits           53128    53128           
  Misses         20285    20285           
  Partials        2706     2706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo otherwise this is fine.

@t2gran
Copy link
Member Author

t2gran commented Dec 11, 2024

✅ The changes made by @optionsome looks good to me, this is ready to be be merged.

@t2gran t2gran requested a review from optionsome December 11, 2024 15:28
@optionsome optionsome merged commit 34cb0c9 into dev-2.x Dec 12, 2024
5 checks passed
@optionsome optionsome deleted the ddr_connecti_realay branch December 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants