Improve logic for transfers in consolidated stops #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6157 +/- ##
==========================================
Coverage 69.90% 69.90%
- Complexity 17709 17710 +1
==========================================
Files 1996 1996
Lines 75330 75328 -2
Branches 7715 7713 -2
==========================================
- Hits 52660 52659 -1
+ Misses 19993 19992 -1
Partials 2677 2677 ☔ View full report in Codecov by Sentry. |
binh-dam-ibigroup
previously approved these changes
Oct 14, 2024
| * Removes walk legs from and to a consolidated stop if they are deemed "short". This means that | ||
| * they are from a different element of the consolidated stop. | ||
| */ | ||
| private void removeWalkLegs(Itinerary itinerary) { |
There was a problem hiding this comment.
Rename to removeShortWalkLegs, and maybe there is a way to consolidate the various conditions?
...on/src/ext/java/org/opentripplanner/ext/stopconsolidation/DecorateConsolidatedStopNames.java
Outdated
Show resolved
Hide resolved
binh-dam-ibigroup
approved these changes
Oct 15, 2024
|
This is a pure sandbox feature and I will merge it without a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves the logic of the consolidated stops according to the latest Arcadis supplied specification: some walk legs are removed when you transfer in consolidated stops.
Unit tests
Added.
Documentation
Javadoc.