-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TransitModelIndex more immutable #6140
Merged
habrahamsson-skanetrafiken
merged 5 commits into
opentripplanner:dev-2.x
from
Skanetrafiken:transit-model-index-immutability-1
Oct 11, 2024
Merged
Make TransitModelIndex more immutable #6140
habrahamsson-skanetrafiken
merged 5 commits into
opentripplanner:dev-2.x
from
Skanetrafiken:transit-model-index-immutability-1
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be even immutabler! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6140 +/- ##
=============================================
- Coverage 69.85% 69.84% -0.02%
- Complexity 17491 17669 +178
=============================================
Files 1976 1995 +19
Lines 74712 75267 +555
Branches 7645 7702 +57
=============================================
+ Hits 52192 52571 +379
- Misses 19868 20024 +156
- Partials 2652 2672 +20 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
added
the
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
label
Oct 10, 2024
leonardehrenfried
previously approved these changes
Oct 11, 2024
optionsome
reviewed
Oct 11, 2024
src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
Outdated
Show resolved
Hide resolved
habrahamsson-skanetrafiken
requested review from
optionsome and
leonardehrenfried
October 11, 2024 12:42
leonardehrenfried
approved these changes
Oct 11, 2024
optionsome
approved these changes
Oct 11, 2024
habrahamsson-skanetrafiken
merged commit Oct 11, 2024
1e8ff41
into
opentripplanner:dev-2.x
5 checks passed
t2gran
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Skip Changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR:
TransitModelIndex
.TransitModelIndex
unmodifiable.TransitModelIndex
that already exists inTransitModel
.Issue
See #6048
Unit tests
Some of the stuff in TransitModelIndex is untested. I didn't add any tests.
Documentation
Didn't add any documentation.
Bumping the serialization version id
I guess, since I'm changing the signature of the TransitModel?