Update code style for ordering things inside classes #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6125 +/- ##
==========================================
Coverage 69.85% 69.86%
+ Complexity 17497 17495 -2
==========================================
Files 1976 1976
Lines 74710 74712 +2
Branches 7645 7645
==========================================
+ Hits 52191 52194 +3
Misses 19868 19868
+ Partials 2651 2650 -1 ☔ View full report in Codecov by Sentry. |
t2gran
reviewed
Oct 10, 2024
Co-authored-by: Thomas Gran <[email protected]>
t2gran
approved these changes
Oct 10, 2024
leonardehrenfried
previously approved these changes
Oct 10, 2024
habrahamsson-skanetrafiken
requested changes
Oct 10, 2024
doc/dev/decisionrecords/Codestyle.md
Outdated
Comment on lines
131
to
133
| 5. Each section of members are sorted by visibility: | ||
| 1. ´public´ | ||
| 2. package private |
There was a problem hiding this comment.
This part says that we should sort the sections above by visibility. That collides with having the private specifiers above.
Maybe we should just remove this section?
t2gran
requested changes
Oct 10, 2024
Co-authored-by: Thomas Gran <[email protected]>
optionsome
requested review from
t2gran,
habrahamsson-skanetrafiken and
leonardehrenfried
t2gran
approved these changes
Oct 10, 2024
habrahamsson-skanetrafiken
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have too strict rules for ordering things inside classes which are not always followed either by accident or because following them would cause nasty conflicts when things need to be moved inside classes. This pr updates the code style for ordering things inside classes to have less rules.
Issue
No issue
Unit tests
Not needed
Documentation
Updated code style documentation.
Changelog
No change log entry since this is meant for developers