Clarify @Nullable and @Nonnull usage [ci skip] #6095
Conversation
optionsome
added
Documentation
Skip Changelog
Developer Decision Record
|
I wasn't completely sure what is our stance on these so we can discuss this quickly in a developer meeting next week. |
leonardehrenfried
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6095 +/- ##
==========================================
Coverage 69.93% 69.93%
+ Complexity 17730 17729 -1
==========================================
Files 1996 1996
Lines 75402 75402
Branches 7717 7717
==========================================
Hits 52731 52731
Misses 19995 19995
Partials 2676 2676 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Henrik Abrahamsson <[email protected]>
|
Through a quick google search, I found out that there might already be a maven plugin that could be used to generate package-info files for us https://github.com/bohnman/package-info-maven-plugin. It isn't the most popular or most actively developed project and I haven't tried yet if it works in practice. Is it worth trying? What do you think @t2gran @habrahamsson-skanetrafiken ? |
|
Although seems like the maintainer has announced he has no time to maintain it and there is a new fork of it https://github.com/willhains/package-info-maven-plugin |
pom.xml
Outdated
| <artifactId>package-info-maven-plugin</artifactId> | ||
| <version>1.1.0</version> | ||
| <configuration> | ||
| <!-- Couldn't get this to work for main and ext code at the same time. --> |
There was a problem hiding this comment.
Sorry Joel for not looking at this before, but if you want 2 executions with different config, then you create two execution blocks and move the config inside the execution. This is the default, so moving only the sourceDirectory should be enough. This is however good enough.
Summary
Trying to clarify which annotations should be used in code.
Issue
No issue as minor code conventions clarification.
Unit tests
No
Documentation
Touched documentation
Changelog
No need