Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coach, cable tram and trolleybus GTFS route types #6086

Closed
wants to merge 9 commits into from
Closed

Fix coach, cable tram and trolleybus GTFS route types #6086

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bfbd2a2
fix GTFS coach and trolleybus service
miklcct Sep 23, 2024
a43adb6
Merge remote-tracking branch 'upstream/dev-2.x' into coach_gtfs
miklcct Sep 25, 2024
01e04a9
Add tests for existing GTFS to OTP modes
miklcct Sep 25, 2024
9fae344
separate bus and coach in API
miklcct Sep 25, 2024
149e07d
update the description of "CABLE_CAR" mode to cable tram. Also fix Tr…
miklcct Sep 25, 2024
ef78b19
replace all references of "Cable Car" with "Cable Tram" in UI text.
miklcct Sep 25, 2024
f83e9cd
move line comments to separate lines
miklcct Sep 25, 2024
40ea6d1
Merge remote-tracking branch 'upstream/dev-2.x' into coach_gtfs
miklcct Oct 15, 2024
743a0d1
Merge remote-tracking branch 'upstream/dev-2.x' into coach_gtfs
miklcct Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/main/java/org/opentripplanner/gtfs/mapping/TransitModeMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static TransitMode mapMode(int routeType) {
if (routeType >= 100 && routeType < 200) { // Railway Service
return TransitMode.RAIL;
} else if (routeType >= 200 && routeType < 300) { //Coach Service
miklcct marked this conversation as resolved.
Show resolved Hide resolved
return TransitMode.BUS;
return TransitMode.COACH;
} else if (routeType >= 300 && routeType < 500) { //Suburban Railway Service and Urban Railway service
if (routeType >= 401 && routeType <= 402) {
return TransitMode.SUBWAY;
Expand All @@ -30,11 +30,10 @@ public static TransitMode mapMode(int routeType) {
return TransitMode.RAIL;
} else if (routeType >= 500 && routeType < 700) { //Metro Service and Underground Service
return TransitMode.SUBWAY;
} else if (routeType >= 700 && routeType < 900) { //Bus Service and Trolleybus service
if (routeType == 800) {
return TransitMode.TROLLEYBUS;
}
} else if (routeType >= 700 && routeType < 800) { //Bus Service
return TransitMode.BUS;
} else if (routeType >= 800 && routeType < 900) { //Trolleybus Service
return TransitMode.TROLLEYBUS;
} else if (routeType >= 900 && routeType < 1000) { //Tram service
return TransitMode.TRAM;
} else if (routeType >= 1000 && routeType < 1100) { //Water Transport Service
Expand Down
Loading