SIRI-FM vehicle parking updates #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5979 +/- ##
=============================================
+ Coverage 69.73% 69.74% +0.01%
- Complexity 17292 17317 +25
=============================================
Files 1954 1960 +6
Lines 74163 74261 +98
Branches 7595 7603 +8
=============================================
+ Hits 51714 51791 +77
- Misses 19809 19830 +21
Partials 2640 2640 ☔ View full report in Codecov by Sentry. |
|
cc @rcavaliere @clezag. |
leonardehrenfried
force-pushed
the
siri-parking-updates
branch
2 times, most recently
from
50b9f10 to
cc7d540
Compare
leonardehrenfried
force-pushed
the
siri-parking-updates
branch
from
30dca85 to
b70dc74
Compare
optionsome
reviewed
Aug 2, 2024
| .ofNullable(siri.getServiceDelivery()) | ||
| .flatMap(sd -> sd.getFacilityMonitoringDeliveries().stream()) | ||
| .flatMap(d -> d.getFacilityConditions().stream()) | ||
| .filter(this::conformsToItalianProfile) |
There was a problem hiding this comment.
This check feels a bit ugly but I guess it's well-documented that this updater follows the italian profile and we can refactor the profile to be configurable when there is need for it.
...main/java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdater.java
Outdated
Show resolved
Hide resolved
.../java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdaterTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Lappalainen <[email protected]>
optionsome
previously approved these changes
Aug 6, 2024
vpaturet
requested changes
Aug 8, 2024
...main/java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdater.java
Outdated
Show resolved
Hide resolved
...main/java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdater.java
Show resolved
Hide resolved
vpaturet
approved these changes
Aug 9, 2024
optionsome
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on #5946 this adds a vehicle parking updater that consumes SIRI-FM.
It introduces a new model for parking updates: rather than being able to add parking lots through a realtime updater, this only updates the availability.
We can discuss in the dev meetings, if these two update types should be handled in the same updater.
Unit tests
Added.
For the time being, this is a draft as I want to wait until #5946 has been merged.