Add car rental to Transmodel street mode options #5977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5977 +/- ##
=============================================
+ Coverage 69.64% 69.65% +0.01%
- Complexity 17140 17157 +17
=============================================
Files 1937 1942 +5
Lines 73747 73787 +40
Branches 7546 7550 +4
=============================================
+ Hits 51362 51400 +38
- Misses 19753 19757 +4
+ Partials 2632 2630 -2 ☔ View full report in Codecov by Sentry. |
jtorin
reviewed
Jul 23, 2024
src/main/java/org/opentripplanner/apis/transmodel/model/EnumTypes.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql
Outdated
Show resolved
Hide resolved
Co-authored-by: Johan Torin <[email protected]>
jtorin
approved these changes
Jul 24, 2024
vpaturet
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that the new debug UI uses the Transmodel API @hbruch has reported that car rental is missing from its street modes.
This PR adds it.
It also makes a new line change in the
/clientfolder in order to trigger a rebuild of the debug UI so that the GraphQL schema is also rebuild and the new item shows up in the debug UI.