-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce non-null coordinates on multimodal station #5971
Merged
vpaturet
merged 3 commits into
opentripplanner:dev-2.x
from
entur:enforce_non_null_coordinates_on_multimodal_station
Jul 16, 2024
Merged
Enforce non-null coordinates on multimodal station #5971
vpaturet
merged 3 commits into
opentripplanner:dev-2.x
from
entur:enforce_non_null_coordinates_on_multimodal_station
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5971 +/- ##
==========================================
Coverage 69.63% 69.64%
- Complexity 17129 17134 +5
==========================================
Files 1937 1937
Lines 73741 73743 +2
Branches 7546 7547 +1
==========================================
+ Hits 51350 51357 +7
+ Misses 19754 19752 -2
+ Partials 2637 2634 -3 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
previously approved these changes
Jul 16, 2024
vpaturet
force-pushed
the
enforce_non_null_coordinates_on_multimodal_station
branch
from
July 16, 2024 13:30
dcbf86c
to
5bc0b78
Compare
src/test/java/org/opentripplanner/netex/mapping/MultiModalStationMapperTest.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
approved these changes
Jul 16, 2024
abyrd
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When querying a multimodal station without coordinates through the GraphQL API, the call fails with a NullPointerException:
This PR ensures that multimodal stations without coordinates are ignored during graph building.
Issue
No
Unit tests
Updated unit tests
Documentation
No