Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose mutable tripOnServiceDates in TransitModel #5842

Conversation

habrahamsson-skanetrafiken
Copy link
Contributor

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken commented May 14, 2024

Summary

Just a minor cleanup to not expose a mutable map and instead provide TransitModel.addTripOnServiceDate()

Encapsulation, loose coupling etc.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.91%. Comparing base (5b3be61) to head (07aab67).
Report is 27 commits behind head on dev-2.x.

Files Patch % Lines
...in/java/org/opentripplanner/netex/NetexModule.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5842      +/-   ##
=============================================
+ Coverage      67.90%   67.91%   +0.01%     
+ Complexity     16567    16561       -6     
=============================================
  Files           1910     1910              
  Lines          72418    72439      +21     
  Branches        7444     7444              
=============================================
+ Hits           49173    49199      +26     
+ Misses         20724    20720       -4     
+ Partials        2521     2520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried requested a review from t2gran May 14, 2024 09:30
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I checked, dated trips are only added during NeTEx graph build. It is potensialy dangerous to use during routing.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken merged commit 21f50ba into opentripplanner:dev-2.x May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants