Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug UI smoke tests #5617

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

testower
Copy link
Contributor

@testower testower commented Jan 11, 2024

Summary

Basic smoke test, to build more confidence in PRs, especially dependency upgrades.

@testower testower changed the title Add alias for missing optional peer dependency Debug UI smoke tests Jan 11, 2024
@testower testower force-pushed the improve/debug-ui-smoke-test branch from 4e332ec to 3ddb9f7 Compare January 11, 2024 13:12
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7d037e) 67.63% compared to head (da66cb1) 67.63%.
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5617      +/-   ##
=============================================
- Coverage      67.63%   67.63%   -0.01%     
  Complexity     16298    16298              
=============================================
  Files           1886     1886              
  Lines          71552    71554       +2     
  Branches        7387     7387              
=============================================
+ Hits           48393    48394       +1     
  Misses         20654    20654              
- Partials        2505     2506       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@testower testower force-pushed the improve/debug-ui-smoke-test branch from 3ddb9f7 to 0659f24 Compare January 11, 2024 13:20
@testower testower force-pushed the improve/debug-ui-smoke-test branch 5 times, most recently from cfbd72d to 166c7b5 Compare January 12, 2024 12:57
@t2gran t2gran added this to the 2.5 (next release) milestone Jan 17, 2024
Due to huge issues with mocking mapbox-gl, smoke tests on search bar and itinerary list.
@testower testower force-pushed the improve/debug-ui-smoke-test branch from 166c7b5 to 0f63b2f Compare February 14, 2024 09:09
@testower testower marked this pull request as ready for review February 14, 2024 09:09
@testower testower requested a review from a team as a code owner February 14, 2024 09:09
@testower
Copy link
Contributor Author

@optionsome would you be so kind as to give the "there's no java code touched in this PR"-thumbsup? 😄

@testower testower merged commit 2ede3be into opentripplanner:dev-2.x Feb 15, 2024
6 checks passed
@t2gran t2gran deleted the improve/debug-ui-smoke-test branch October 9, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants