-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug UI smoke tests #5617
Merged
testower
merged 2 commits into
opentripplanner:dev-2.x
from
entur:improve/debug-ui-smoke-test
Feb 15, 2024
Merged
Debug UI smoke tests #5617
testower
merged 2 commits into
opentripplanner:dev-2.x
from
entur:improve/debug-ui-smoke-test
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testower
changed the title
Add alias for missing optional peer dependency
Debug UI smoke tests
Jan 11, 2024
testower
force-pushed
the
improve/debug-ui-smoke-test
branch
from
January 11, 2024 13:12
4e332ec
to
3ddb9f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5617 +/- ##
=============================================
- Coverage 67.63% 67.63% -0.01%
Complexity 16298 16298
=============================================
Files 1886 1886
Lines 71552 71554 +2
Branches 7387 7387
=============================================
+ Hits 48393 48394 +1
Misses 20654 20654
- Partials 2505 2506 +1 ☔ View full report in Codecov by Sentry. |
testower
force-pushed
the
improve/debug-ui-smoke-test
branch
from
January 11, 2024 13:20
3ddb9f7
to
0659f24
Compare
testower
force-pushed
the
improve/debug-ui-smoke-test
branch
5 times, most recently
from
January 12, 2024 12:57
cfbd72d
to
166c7b5
Compare
Due to huge issues with mocking mapbox-gl, smoke tests on search bar and itinerary list.
testower
force-pushed
the
improve/debug-ui-smoke-test
branch
from
February 14, 2024 09:09
166c7b5
to
0f63b2f
Compare
leonardehrenfried
approved these changes
Feb 14, 2024
@optionsome would you be so kind as to give the "there's no java code touched in this PR"-thumbsup? 😄 |
optionsome
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basic smoke test, to build more confidence in PRs, especially dependency upgrades.