Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow boarding/alighting at GroupStops in RAPTOR #4534

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Oct 21, 2022

Summary

In #3757 all StopLocations were added to patterns. It works with RAPTOR, as area stops were always set as not allowed for boarding/alighting. The same should be done also for GroupStops. This changes that and adds a test to validate the behaviour

@hannesj hannesj added the Bug label Oct 21, 2022
@hannesj hannesj added this to the 2.2 milestone Oct 21, 2022
@hannesj hannesj requested a review from a team as a code owner October 21, 2022 08:24
@codecov-commenter
Copy link

Codecov Report

Base: 59.74% // Head: 59.73% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b1f5475) compared to base (1871825).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4534      +/-   ##
=============================================
- Coverage      59.74%   59.73%   -0.02%     
+ Complexity     11901    11897       -4     
=============================================
  Files           1556     1556              
  Lines          62415    62407       -8     
  Branches        6979     6979              
=============================================
- Hits           37292    37278      -14     
- Misses         22965    22972       +7     
+ Partials        2158     2157       -1     
Impacted Files Coverage Δ
...tripplanner/transit/model/network/StopPattern.java 80.58% <100.00%> (ø)
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.14% <0.00%> (-0.96%) ⬇️
...lanner/routing/vehicle_parking/VehicleParking.java 81.95% <0.00%> (-0.76%) ⬇️
.../graph_builder/module/osm/OpenStreetMapModule.java 83.94% <0.00%> (-0.11%) ⬇️
...ipplanner/transit/model/basic/LocalizedString.java 79.16% <0.00%> (ø)
...anner/graph_builder/module/osm/NoteProperties.java 66.66% <0.00%> (ø)
...raph_builder/module/osm/LocalizedStringMapper.java 100.00% <0.00%> (ø)
..._builder/module/configure/GraphBuilderModules.java 0.00% <0.00%> (ø)
...lder/module/osm/specifier/ExactMatchSpecifier.java 100.00% <0.00%> (ø)
...er/module/osm/parameters/OsmDefaultParameters.java 100.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that. I must have forgotten that when I made the change back in the day, because group stops are so rare.

@hannesj hannesj added the Entur Test This is currently being tested at Entur label Oct 21, 2022
@hannesj hannesj merged commit 71c946f into opentripplanner:dev-2.x Oct 21, 2022
@hannesj hannesj deleted the otp2_remove_grip_stops branch October 21, 2022 08:58
t2gran pushed a commit that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Entur Test This is currently being tested at Entur
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants