Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filtering of flex patterns in NeTEX import #4493

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Oct 3, 2022

Summary

Currently we don't import JourneyPatterns with flex stops from NeTEx files. The support for adding these, as well as the corresponding change in GTFS handling was done in #3757.

@hannesj hannesj added Improvement Technical Debt Entur Test This is currently being tested at Entur NeTEx This issue is related to the Netex model/import. labels Oct 3, 2022
@hannesj hannesj added this to the 2.2 milestone Oct 3, 2022
@hannesj hannesj requested a review from t2gran October 3, 2022 11:11
@hannesj hannesj requested a review from a team as a code owner October 3, 2022 11:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 58.55% // Head: 58.60% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (bcf6806) compared to base (4f2325f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4493      +/-   ##
=============================================
+ Coverage      58.55%   58.60%   +0.05%     
- Complexity     11485    11517      +32     
=============================================
  Files           1515     1517       +2     
  Lines          60309    60536     +227     
  Branches        6842     6885      +43     
=============================================
+ Hits           35313    35477     +164     
- Misses         22928    22974      +46     
- Partials        2068     2085      +17     
Impacted Files Coverage Δ
...api/model/timetable/TimetabledPassingTimeType.java 85.86% <0.00%> (-2.90%) ⬇️
...entripplanner/netex/mapping/TripPatternMapper.java 75.42% <ø> (+0.62%) ⬆️
...ripplanner/model/transfer/ConstrainedTransfer.java 83.33% <0.00%> (-3.34%) ⬇️
.../opentripplanner/ext/fares/FaresConfiguration.java 40.00% <0.00%> (-3.34%) ⬇️
...g/opentripplanner/updater/GraphUpdaterManager.java 51.89% <0.00%> (-2.54%) ⬇️
...org/opentripplanner/netex/mapping/NetexMapper.java 80.25% <0.00%> (-1.61%) ⬇️
...planner/ext/transmodelapi/model/stop/QuayType.java 72.98% <0.00%> (-0.24%) ⬇️
...ava/org/opentripplanner/routing/core/FareType.java 100.00% <0.00%> (ø)
...org/opentripplanner/util/lang/ToStringBuilder.java 100.00% <0.00%> (ø)
...ripplanner/netex/mapping/StopAndStationMapper.java 81.48% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBI ha been running with these flex stops in the trip times for many month and we have not noticed problems.

@hannesj hannesj merged commit ffe9990 into opentripplanner:dev-2.x Oct 4, 2022
@hannesj hannesj deleted the otp2_flex_patterns branch October 4, 2022 16:15
t2gran pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entur Test This is currently being tested at Entur Improvement NeTEx This issue is related to the Netex model/import. Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants