Merge pull request #5642 from opentripplanner/abyrd/realtime-startup-…

…logging Make logging of MQTT realtime updater more uniform
opentripplanner · Mar 21, 2024 · 29b0010 · 29b0010
2 parents 2b7a431 + c80651c
commit 29b0010
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/main/java/org/opentripplanner/updater/alert/GtfsRealtimeAlertsUpdater.java b/src/main/java/org/opentripplanner/updater/alert/GtfsRealtimeAlertsUpdater.java
@@ -51,11 +51,7 @@ public GtfsRealtimeAlertsUpdater(
     this.updateHandler.setTransitAlertService(transitAlertService);
     this.updateHandler.setFuzzyTripMatcher(fuzzyTripMatcher);
     this.otpHttpClient = new OtpHttpClient();
-    LOG.info(
-      "Creating real-time alert updater running every {} seconds : {}",
-      pollingPeriod(),
-      url
-    );
+    LOG.info("Creating real-time alert updater running every {}: {}", pollingPeriod(), url);
   }
 
   @Override

diff --git a/src/main/java/org/opentripplanner/updater/trip/MqttGtfsRealtimeUpdater.java b/src/main/java/org/opentripplanner/updater/trip/MqttGtfsRealtimeUpdater.java
@@ -13,6 +13,7 @@
 import org.eclipse.paho.client.mqttv3.MqttException;
 import org.eclipse.paho.client.mqttv3.MqttMessage;
 import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence;
+import org.opentripplanner.framework.tostring.ToStringBuilder;
 import org.opentripplanner.transit.service.DefaultTransitService;
 import org.opentripplanner.transit.service.TransitModel;
 import org.opentripplanner.updater.GtfsRealtimeFuzzyTripMatcher;
@@ -78,6 +79,7 @@ public MqttGtfsRealtimeUpdater(
         new GtfsRealtimeFuzzyTripMatcher(new DefaultTransitService(transitModel));
     }
     this.recordMetrics = TripUpdateMetrics.streaming(parameters);
+    LOG.info("Creating streaming GTFS-RT TripUpdate updater subscribing to MQTT broker at {}", url);
   }
 
   @Override
@@ -187,4 +189,14 @@ public void messageArrived(String topic, MqttMessage message) {
     @Override
     public void deliveryComplete(IMqttDeliveryToken token) {}
   }
+
+  @Override
+  public String toString() {
+    return ToStringBuilder
+      .of(MqttGtfsRealtimeUpdater.class)
+      .addStr("url", url)
+      .addStr("topic", topic)
+      .addStr("feedId", feedId)
+      .toString();
+  }
 }