fix check when range is required

opentripplanner · Dec 17, 2024 · 086effd · 086effd
1 parent c9c3a66
commit 086effd
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/...a/org/opentripplanner/updater/vehicle_rental/datasources/GbfsFreeVehicleStatusMapper.java b/...a/org/opentripplanner/updater/vehicle_rental/datasources/GbfsFreeVehicleStatusMapper.java
@@ -83,14 +83,12 @@ public VehicleRentalVehicle mapFreeVehicleStatus(GBFSBike vehicle) {
           vehicle.getCurrentRangeMeters(),
           e.getMessage()
         );
-        // if the propulsion type has an engine current_range_meters is required
-        if (
-          vehicle.getVehicleTypeId() != null &&
-          vehicleTypes.get(vehicle.getVehicleTypeId()).propulsionType !=
-          RentalVehicleType.PropulsionType.HUMAN
-        ) {
-          return null;
-        }
+      }
+      // if the propulsion type has an engine current_range_meters is required
+      if (vehicle.getVehicleTypeId() != null
+        && vehicleTypes.get(vehicle.getVehicleTypeId()).propulsionType != RentalVehicleType.PropulsionType.HUMAN
+        && rangeMeters == null) {
+        return null;
       }
       rentalVehicle.fuel = new RentalVehicleFuel(fuelPercent, rangeMeters);
       rentalVehicle.pricingPlanId = vehicle.getPricingPlanId();