Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

add tracer close #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
History
-------

0.14.5
-------------------
- Add trace close interface

0.14.4
-------------------
- Add trace identifiers to the `SpanContext`
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "opentracing",
"version": "0.14.4",
"version": "0.14.5",
"engines": {
"node": ">=0.10"
},
Expand Down
8 changes: 7 additions & 1 deletion src/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class Tracer {
} else {
options.references = [childOf];
}
delete(options.childOf);
delete (options.childOf);
}
return this._startSpan(name, options);
}
Expand Down Expand Up @@ -177,6 +177,12 @@ export class Tracer {
protected _extract(format: string, carrier: any): SpanContext | null {
return Noop.spanContext!;
}

// close the tracer,flushes spans, and executes any callbacks if necessary

protected close(callback?: void): void {

}
}

export default Tracer;