Do not use AbstractTag<T> for Span.setTag(), but the actual impls.

[carlosalberto]

This is done to not use an abstract class for our public API,
so we take overloads of BooleanTag, IntTag and StringTag.

Addresses a small detail mentioned in #314

@yurishkuro @tylerbenson

[coveralls]

Coverage decreased (-0.2%) to 76.483% when pulling 7e8cbe8 on carlosalberto:span_settag_with_types into b6f6324 on opentracing:v0.32.0.

[carlosalberto]

Hey, any opinion on this @yurishkuro @tylerbenson ? If it looks right, I will merge and this will be included in the RC1 else, we might probably roll it in the next RC ;)

[yurishkuro]

Why not use a typed interface? I'm not a fan of overloaded methods (even though it is consistent with the plain set methods).

[tylerbenson]

I’m ok with this. My understanding is this will perform better because the JIT can optimize the calls more efficiently.

[carlosalberto]

@yurishkuro

You refer to something like this?

// IntTag and the others would be inheriting this class.
public class TypedTag<T> extends AbstractTag<T> {
    protected void set(Span span, T tagValue)
    {   
        span.setTag(super.key, tagValue.toString());
    }
}

[carlosalberto]

Hey @yurishkuro sorry, re-read your message today and figured you simply wanted the same, but through an interface ;)

[yurishkuro]

If you add setValue to the interface you won't need to use object.

[carlosalberto]

Hey @yurishkuro

I added Tag.set() and updated AbstractTag as well - but left the call to MockTracer.setObjectTag() as this extra checks that no tags are added after a Span was finished, and would love to keep it around:

    // An error will be reported if this Span is already finished.
    private synchronized MockSpan setObjectTag(String key, Object value) {
        finishedCheck("Adding tag {%s:%s} to already finished span", key, value);

Let me know ;)

[yurishkuro]

I think it should do tag.set(span, value) instead. This way the correct typed set() method will be called by the tag itself, and those methods would call setObjectTag

[carlosalberto]

@yurishkuro Updated it to looks just like that ;) If you think that's fine, I will merge soon

[yurishkuro]

🚢

[carlosalberto]

👍