Always return NoopScope / NoopSpan for ScopeManager.Active / Tracer.ActiveSpan #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings opentracing/opentracing-java#263 to this repository.
Description from there:
We have a separate
NoopTests
class in our repo so I had to adjust these tests. I also changed everything toAssertSame(Noop*.Instance, ...)
instead ofAssert.IsType<Noop*>(...)
as this is a better check for our use case IMO.As I changed these tests as well, I'll keep this PR open for a few days.