Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include/exclude grpc headers by name #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbf154
Copy link

@jbf154 jbf154 commented Aug 23, 2021

Sometimes headers can contain sensitive information (for example, the Authorization header). This update enables the user to optionally specify a list of headers to:

  • specifically exclude or
  • specifically include

@yurishkuro
Copy link

What relationship does tracing interceptor have with authorization headers?

@jbf154
Copy link
Author

jbf154 commented Aug 23, 2021

If you use any header (like the Authorization header) to transmit sensitive data and have opentracing configured to tag the HTTP headers in the span, that tag will have the contents of the sensitive header. Right now you can disable the HEADERS attribute, but that disables tagging all headers. Sometimes it is useful to tag some headers and omit others, hence this change.

In our use case, we are using OAuth bearer tokens passed into our services using the Authorization header. The tokens are sensitive and ideally would not be included in the spans generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants