fix(transfer): [transfer] fix uncorrect vars for transfer

[MomoPoppy]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Updated color variables for improved clarity in UI components, enhancing visual consistency.
  • Introduced a new variable for sorting icon color in the transfer component.

• Bug Fixes

  • Adjusted sorting icon styling for better alignment and visual representation.

• Documentation

  • Enhanced the organization of color definitions for branding and contextual usage.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the LESS files associated with the theme and transfer components. Key updates include the addition and alteration of CSS custom properties for color definitions in aurora-theme.less, focusing on states like success and error. The transfer component's styling is refined by changing the color property for the sorting icon and updating the selector from an i tag to a class. These changes aim to enhance clarity and maintainability in the theme's design specifications.

Changes

File Path	Change Summary
packages/theme/src/base/aurora-theme.less	Updated color variables for success, error, warning, and information states; modified specific color definitions for consistency.
packages/theme/src/transfer/index.less	Changed sorting icon color property and selector from i to .tiny-svg; removed dimension properties for the icon.
packages/theme/src/transfer/vars.less	Removed --tv-Transfer-header-sort-text-color and added --tv-Transfer-header-sort-icon-color.

Possibly related PRs

• feat: [input] add new vars less #2128: Introduces new variables related to the LESS stylesheet language, complementing changes in aurora-theme.less.
• feat: optimize theme style variables #2157: Optimizes theme style variables, aligning with updates for clarity and usability in the main PR.
• fix(theme): update vars.less comments #2160: Updates comments in vars.less, relating to enhanced clarity of color definitions in the main PR.
• fix(theme): rename warning to base-warn #2182: Renames warning-related variables in vars.less, connecting to changes focusing on color definitions.
• refactor(transfer): [transfer] update css vars  #2320: Updates CSS variables in the transfer component, relating to overall theme variable updates.
• fix(tabs): [tabs] Adapt to the old theme style #2523: Adapts the tabs component to an older theme style, involving similar variable updates.
• feat(old-theme): [dropdown,grid,tree] modify incorrect css vars #2551: Modifies incorrect CSS variables for dropdown, grid, and tree components, relating to overall theme updates.
• fix(dropdown): [dropdown] fix icon shaking when hover #2557: Addresses icon shaking in the dropdown component, connecting to visual consistency goals.
• fix(button): [button,cascader] fix button's radius and cascader bgcolor #2572: Fixes button radius and Cascader background color, aligning with the main PR's focus on theme variables.
• feat(theme): [button] submit the initial version of aurora-theme-vars #2596: Submits the initial version of aurora-theme-vars, directly relating to updates in aurora-theme.less.

Suggested labels

bug

Suggested reviewers

• zzcr

🐰 In the meadow, colors bloom bright,
Variables dance, a wonderful sight.
Icons now twirl, with a new hue,
Clarity reigns, in the theme's view.
With each little change, we hop with delight,
A theme so vibrant, it feels just right! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between da4f7fa and 0dcad25.

📒 Files selected for processing (3)

• packages/theme/src/base/aurora-theme.less (2 hunks)
• packages/theme/src/transfer/index.less (1 hunks)
• packages/theme/src/transfer/vars.less (1 hunks)

🔇 Additional comments (5)

packages/theme/src/transfer/vars.less (1)

118-119: LGTM! Improved variable naming for better semantics

The rename from sort-text-color to sort-icon-color better reflects the actual usage of this variable for styling icons rather than text.

packages/theme/src/transfer/index.less (2)

323-323: LGTM! Consistent variable usage

The color property now correctly uses the renamed icon-specific variable.

---

327-329: LGTM! Improved icon alignment

The addition of vertical-align: text-top improves the visual alignment of SVG icons.

packages/theme/src/base/aurora-theme.less (2)

244-246: LGTM! Consistent info state styling

The background colors for info states are now consistently defined using rgba values.

---

267-267: LGTM! Appropriate color for important text

Changed important text color to use error state color (#f5222d), which is more appropriate for highlighting critical information.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.