-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix color-select-panel error when publish #2583
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)packages/vue/src/color-select-panel/package.json (2)
The change from Also applies to: 21-21
Since the PR title mentions fixing a color-select-panel error during publish, let's verify if similar version specifier issues exist in other packages. Also applies to: 21-21 ✅ Verification successfulWorkspace dependency specifications are consistent and appropriate The verification shows that:
The change aligns with the project's dependency management pattern and should resolve any publishing issues related to version specifiers. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for inconsistent version specifiers in other package.json files
# that might cause similar publishing issues
# Find all package.json files and check for workspace dependencies with '^'
echo "Checking for workspace dependencies using '^' version specifier..."
fd package.json packages/ --type f --exec grep -l "workspace:\^" {} \;
# Also check if there are any other color-select-panel related dependencies
echo -e "\nChecking for color-select-panel dependencies in other packages..."
fd package.json packages/ --type f --exec grep -l "@opentiny/vue-color-select-panel" {} \;
Length of output: 583 Script: #!/bin/bash
# Let's check the actual dependency specifications in these files
echo "Content of packages/vue/package.json dependencies:"
cat packages/vue/package.json | jq '.dependencies["@opentiny/vue-color-select-panel"]'
echo -e "\nContent of packages/vue/src/color-picker/package.json dependencies:"
cat packages/vue/src/color-picker/package.json | jq '.dependencies["@opentiny/vue-color-select-panel"]'
# Let's also check for any other workspace:~ dependencies in color-select-panel
echo -e "\nWorkspace dependencies in color-select-panel/package.json:"
cat packages/vue/src/color-select-panel/package.json | jq '.dependencies | to_entries[] | select(.value | startswith("workspace:~"))'
# Check if there are any workspace:^ dependencies that might cause similar issues
echo -e "\nChecking for workspace:^ dependencies in all package.json files:"
fd package.json packages/ --type f --exec grep "workspace:\^" {} \;
Length of output: 1540 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
@opentiny/vue-option
and@opentiny/vue-select
to allow for more controlled updates.