fix(search): [search] Cancel the border of the search drop-down list box according to the specifications.

[chenxi-20]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style Updates
  • Removed border from the search selector for a cleaner appearance.
  • Updated box shadow for the search dropdown to enhance visual depth.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the LESS stylesheets for the search component within the theme package. Specifically, a border declaration was removed from the & &__selector class in index.less, and the box shadow property for the search selector was updated in vars.less. These adjustments affect the visual styling of the search component without altering its overall functionality or structure.

Changes

File Path	Change Summary
packages/theme/src/search/index.less	Removed the border declaration from & &__selector class.
packages/theme/src/search/vars.less	Updated the box shadow property from var(--tv-shadow-3-up) to var(--tv-shadow-3-down).

Possibly related PRs

• refactor(search): [search] refactor search theme #2186: Refactor of the search theme, including changes to LESS stylesheets for the search component.
• feat(search): [search] Adding borderless examples in mini mode #2091: Introduces borderless examples for the search component in mini mode, aligning with the main PR's visual styling changes.
• feat(search): [search] The vertical bar on the right of the star theme close button is added. #2084: Adds new styles for a close button within the search input component, relating to overall styling adjustments.
• fix(theme): fix error css vars #2338: Addresses issues with CSS variable references that could impact the styling of the search component.

Suggested labels

bug

Suggested reviewers

• zzcr

Poem

In the meadow, where shadows play,
The search box shines, bright as day.
Borders gone, a sleek new look,
With shadows dancing, like a book.
Hopping along, we cheer with glee,
For style and grace, as fine as can be! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/theme/src/search/vars.less (1)

59-59: Consider documenting the design specification reference.

While this change implements the specified design requirements, it would be helpful to add a comment referencing the relevant design specification or UI guideline for future maintenance.

  // 搜索下拉框阴影
- --tv-Search-selector-box-shadow: var(--tv-shadow-3-down);
+ // Design spec: [Add link to design spec or ticket]
+ --tv-Search-selector-box-shadow: var(--tv-shadow-3-down);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cd290c5 and 75acd5c.

📒 Files selected for processing (2)

• packages/theme/src/search/index.less (0 hunks)
• packages/theme/src/search/vars.less (1 hunks)

💤 Files with no reviewable changes (1)

• packages/theme/src/search/index.less

🔇 Additional comments (1)

packages/theme/src/search/vars.less (1)

59-59: LGTM! Shadow direction change aligns with modern dropdown patterns.

The change from --tv-shadow-3-up to --tv-shadow-3-down combined with border removal (in index.less) follows contemporary dropdown design patterns, where elements appear to float below their triggers.