-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed stack-buffer-overflow in metric_len #503
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@nandedkarhrish thanks for submitting this fix. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@abtink maybe the failure was due to CLA signing. Signed the CLA just now. |
@nandedkarhrishi, @googlebot is now indicating that the commit is authored by a different author (@dot11monk). Can you ensure that the author matches your contact information or that @dot11monk has signed the Google CLA? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@jwhui thank you for helping. |
@nandedkarhrishi, as mentioned, the commit is showing @dot11monk as the author. See screenshot: |
@jwhui, confirmed, the handle dot11monk belongs to me, but is connected to different account, which was almost never used. |
@googlebot I fixed it..
…On Tue, Jun 29, 2021 at 3:00 AM google-cla[bot] ***@***.***> wrote:
We found a Contributor License Agreement for you (the sender of this pull
request), but were unable to find agreements for all the commit author(s)
or Co-authors. If you authored these, maybe you used a different email
address in the git commits than was used to sign the CLA (login here
<https://cla.developers.google.com/> to double check)? If these were
authored by someone else, then they will need to sign a CLA as well, and
confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot
I fixed it.. If the bot doesn't comment, it means it doesn't think
anything has changed.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fopenthread%2Fwpantund%2Fpull%2F503>
for more info*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#503 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5WRP5IF2TNOEMMQIQZ4G3TVDSXVANCNFSM47NGEQZA>
.
--
*regards,*
*mit is god*
|
@nandedkarhrishi what @jwhui means is that you change the author of the commit to the same as you have for your signed CLA and re-push the PR. Looking at the PR it is still the dot11monk handle. Changing the git author will be a lot easier than the one for the CLA, I assume. :-) |
Fixed stack-buffer-overflow in metric_len reported at #502.