Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stack-buffer-overflow in metric_len #503

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

nandedkarhrishi
Copy link
Contributor

Fixed stack-buffer-overflow in metric_len reported at #502.

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jwhui jwhui requested a review from abtink June 28, 2021 15:24
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abtink
Copy link
Member

abtink commented Jun 28, 2021

@nandedkarhrish thanks for submitting this fix.
I see CLA is failing on this PR. Can you please help check this? Thanks. #503 (comment)

@nandedkarhrishi
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@nandedkarhrishi
Copy link
Contributor Author

@abtink maybe the failure was due to CLA signing. Signed the CLA just now.

@jwhui
Copy link
Member

jwhui commented Jun 28, 2021

@abtink maybe the failure was due to CLA signing. Signed the CLA just now.

@nandedkarhrishi, @googlebot is now indicating that the commit is authored by a different author (@dot11monk). Can you ensure that the author matches your contact information or that @dot11monk has signed the Google CLA?

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@nandedkarhrishi
Copy link
Contributor Author

@jwhui thank you for helping.
The commit is authored by me alone. There are no other authors involved. As per github profile, the handle says nandedkarhrishi. Please suggest.

@jwhui
Copy link
Member

jwhui commented Jun 28, 2021

@jwhui thank you for helping.
The commit is authored by me alone. There are no other authors involved. As per github profile, the handle says nandedkarhrishi. Please suggest.

@nandedkarhrishi, as mentioned, the commit is showing @dot11monk as the author. See screenshot:

Screen Shot 2021-06-28 at 2 40 00 PM

@nandedkarhrishi
Copy link
Contributor Author

@jwhui, confirmed, the handle dot11monk belongs to me, but is connected to different account, which was almost never used.
My apologies for hassle.

@dot11monk
Copy link
Contributor

dot11monk commented Jun 28, 2021 via email

@Stefan-Schmidt
Copy link
Contributor

@nandedkarhrishi what @jwhui means is that you change the author of the commit to the same as you have for your signed CLA and re-push the PR. Looking at the PR it is still the dot11monk handle. Changing the git author will be a lot easier than the one for the CLA, I assume. :-)

@jwhui jwhui merged commit a8f3f76 into openthread:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants