-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Get rid of py-substrate-interface (DO NOT MERGE) #2565
Merged
thewhaleking
merged 127 commits into
feat/thewhaleking/new-sync-substrate
from
feat/roman/async-to-sync-via-wrapper
Jan 8, 2025
Merged
[SDK] Get rid of py-substrate-interface (DO NOT MERGE) #2565
thewhaleking
merged 127 commits into
feat/thewhaleking/new-sync-substrate
from
feat/roman/async-to-sync-via-wrapper
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, add subtensor (sync/async) transfer calls
…Pass `_mock` correctly to SubstrateInterface.
…bstrate Optimisations and tests for Async Sync Subtensor
… with IDEs or whatever.
roman-opentensor
changed the title
[SDK] Get rid of py-substrate-interface (WIP)
[SDK] Get rid of py-substrate-interface (DO NOT MERGE)
Jan 8, 2025
thewhaleking
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment that I'm not so sure about. Other than that, LGTM.
thewhaleking
approved these changes
Jan 8, 2025
thewhaleking
merged commit Jan 8, 2025
af6396d
into
feat/thewhaleking/new-sync-substrate
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The ultimate goal is to focus on async development and no longer depend on the outdated
py-substrate-interface
library.At the same time, at least temporarily, we need to maintain backward compatibility with the current implementation of Bittensor SDK. After merging this PR, we will not have to support 2 versions of the code. It will be enough to implement new functions in the asynchronous version and use a wrapper for a sync calls.
Advantages:
AC:
coroutine executor
bittensor.core.chain_data.WeightCommitInfo
class for CRv3 dataMetagraph
with the ability to use it in synchronous codeRelated links:
NOTE: This description could be updated