-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode menu #5336
base: master
Are you sure you want to change the base?
Dark mode menu #5336
Conversation
2789d58
to
e7a22cd
Compare
}, | ||
{ | ||
name: "invert", | ||
filter: "invert(.8) hue-rotate(180deg)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .8 has pretty weak contrast and would suggest .95 instead. Or provide several options, like .8, .9, .95 and 1.
Will 100% brightness be the default? From what I understand to be the sole criticism (mine included) of the initial introduction dark mode was the dimmed map. |
Seriously if we have to do this then we should just give up - it's not so much user friendly as user hostile to be giving space to something like this that is going to be completely incomprehensible to most users. |
There was your suggestion to put the configuration into the preferences, and I kind of like it. Maybe a dropdown that allows you to choose how you'd like it to be. (There should be a map on the preference page then to preview the setting.) |
No it wasn't. There are at least three different groups that complain:
|
@mxdanger Sorry, I overrwrote your comment and there seems to be no undo in Github UI. You said that there's an overwhelming feedback for not modifying the map and asked what should be the default. But there is a feedback for doing inverse+hue-rotate transform. |
Dark mode filter menu from #4777 but without dark transport map tiles.
Unfortunately the context menu gets too large for small screens. Putting the options into the layer select sidebar may work better.