Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt striped table override to dark mode #4652

Closed

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Apr 6, 2024

See #2332 (comment) for how striped tables currently look in dark mode.

This change keeps the current "striped" color in light mode, while in dark mode it looks like this:
image

Another option would be removing this override and using the standard colors.

@tomhughes
Copy link
Member

Can you explain why this works? It's changing from a pale grey to a light purple but also using an alpha channel to make it mostly transparent?

Out of interest I looked at the default colours - that would give us this:

image

instead of this:

image

which I personally think is fine except possible that it makes the striping very close to the header colour - probably it's the secondary colour so would in fact be the same as the heading if we switch that to secondary in #4651.

@AntonKhorev
Copy link
Collaborator Author

One thing I didn't like about the default stripe color is that it's darker than bg-body-tertiary I tried to use for the heading in #4651.

@AntonKhorev AntonKhorev closed this Apr 8, 2024
@AntonKhorev AntonKhorev deleted the dark-mode-table-striped branch April 8, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants