Skip to content

Commit

Permalink
Disable some rules for crd schema check
Browse files Browse the repository at this point in the history
NoFieldRemoval and NoNewRequiredFields need to be temporarily disabled
since we're currently building the crds as we go.
ConditionsMustHaveProperSSATags and ListsMustHaveSSATags are disabled
beacuse they affect the Conditions type defined in lib-common, so they
are not specific to watcher-operator.
  • Loading branch information
cescgina authored and openshift-merge-bot[bot] committed Nov 29, 2024
1 parent 7cf11a2 commit 5f77b5f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hack/crd-schema-checker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ for crd in config/crd/bases/*.yaml; do
git show "$BASE_REF:$crd" > "$TMP_DIR/$crd"
$CHECKER check-manifests \
--existing-crd-filename="$TMP_DIR/$crd" \
--disabled-validators="NoFieldRemoval,NoNewRequiredFields,ConditionsMustHaveProperSSATags,ListsMustHaveSSATags" \
--new-crd-filename="$crd"
done

0 comments on commit 5f77b5f

Please sign in to comment.