Added controller for running ansible playbooks #97

eshulman2 · 2024-05-21T11:29:46Z

This addition should be flexible enough to run
ansible playbooks for testing popuses.
it is dependent on this patch
openstack-k8s-operators/tcib#182

softwarefactory-project-zuul · 2024-05-21T11:39:48Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/aad46f8a405f443aa6272c7f768254d4

❌ openstack-k8s-operators-content-provider FAILURE in 8m 04s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

lpiwowar · 2024-05-21T11:46:46Z

Hi @eshulman2, thanks for the PR! This is going to be helpful once we merge this!

I will do a deeper review a little bit later but in the meantime there are some failures that need to be fixed [1]:

 # github.com/openstack-k8s-operators/test-operator/controllers
2024-05-21 07:39:12.311503 | controller |     controllers/trex_performance_controller.go:21:2: "fmt" imported and not used
2024-05-21 07:39:12.311509 | controller |     controllers/trex_performance_controller.go:168:3: not enough arguments in call to r.EnsureLogsPVCExists
2024-05-21 07:39:12.311516 | controller |             have (context.Context, *"github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformance, *helper.Helper, map[string]string, string)
2024-05-21 07:39:12.311522 | controller |             want (context.Context, client.Object, *helper.Helper, map[string]string, string, bool)
2024-05-21 07:39:12.311533 | controller |     controllers/trex_performance_controller.go:273:24: instance.Spec.TrexPerformanceSpec undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceSpec has no field or method TrexPerformanceSpec)
2024-05-21 07:39:12.311542 | controller |     controllers/trex_performance_controller.go:276:51: instance.Spec.Workflow[workflowStepNum].TrexPerformanceSpec undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceWorkflowSpec has no field or method TrexPerformanceSpec)
2024-05-21 07:39:12.311550 | controller |     controllers/trex_performance_controller.go:282:58: wtRun.Serial undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceWorkflowSpec has no field or method Serial)
2024-05-21 07:39:12.311557 | controller |     controllers/trex_performance_controller.go:290:2: undefined: value
2024-05-21 07:39:12.311563 | controller |     controllers/trex_performance_controller.go:291:9: undefined: value
2024-05-21 07:39:12.311570 | controller |     controllers/trex_performance_controller.go:292:40: undefined: value
2024-05-21 07:39:12.311576 | controller |     controllers/trex_performance_controller.go:297:6: mergeWithWorkflow redeclared in this block
2024-05-21 07:39:12.311583 | controller |             controllers/tempest_controller.go:471:6: other declaration of mergeWithWorkflow
2024-05-21 07:39:12.311589 | controller |     controllers/trex_performance_controller.go:317:62: undefined: tempest
2024-05-21 07:39:12.311604 | controller |     controllers/trex_performance_controller.go:21:2: too many errors

I recommend at least running the test-operator with make install run before pushing the change. It looks like copy paste issues from the tempest part that should be easy to fix and some undefined variables.

[1] https://logserver.rdoproject.org/97/97/77d2a159a959cc584d3f36d7305e3202c1e412f0/github-check/openstack-k8s-operators-content-provider/d166321/job-output.txt

softwarefactory-project-zuul · 2024-05-21T13:32:36Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b44f1c923d474454befe1cc2fc0c47f3

❌ openstack-k8s-operators-content-provider FAILURE in 8m 17s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2024-05-22T11:04:38Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a4bc558a6b474eb99f0be5b432535654

❌ openstack-k8s-operators-content-provider FAILURE in 8m 35s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2024-05-22T11:24:35Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2fcf0b95929d438e844430ca54b503b9

❌ openstack-k8s-operators-content-provider FAILURE in 8m 52s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

eshulman2 · 2024-05-22T15:18:57Z

Hi @eshulman2, thanks for the PR! This is going to be helpful once we merge this!

I will do a deeper review a little bit later but in the meantime there are some failures that need to be fixed [1]:

 # github.com/openstack-k8s-operators/test-operator/controllers
2024-05-21 07:39:12.311503 | controller |     controllers/trex_performance_controller.go:21:2: "fmt" imported and not used
2024-05-21 07:39:12.311509 | controller |     controllers/trex_performance_controller.go:168:3: not enough arguments in call to r.EnsureLogsPVCExists
2024-05-21 07:39:12.311516 | controller |             have (context.Context, *"github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformance, *helper.Helper, map[string]string, string)
2024-05-21 07:39:12.311522 | controller |             want (context.Context, client.Object, *helper.Helper, map[string]string, string, bool)
2024-05-21 07:39:12.311533 | controller |     controllers/trex_performance_controller.go:273:24: instance.Spec.TrexPerformanceSpec undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceSpec has no field or method TrexPerformanceSpec)
2024-05-21 07:39:12.311542 | controller |     controllers/trex_performance_controller.go:276:51: instance.Spec.Workflow[workflowStepNum].TrexPerformanceSpec undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceWorkflowSpec has no field or method TrexPerformanceSpec)
2024-05-21 07:39:12.311550 | controller |     controllers/trex_performance_controller.go:282:58: wtRun.Serial undefined (type "github.com/openstack-k8s-operators/test-operator/api/v1beta1".TrexPerformanceWorkflowSpec has no field or method Serial)
2024-05-21 07:39:12.311557 | controller |     controllers/trex_performance_controller.go:290:2: undefined: value
2024-05-21 07:39:12.311563 | controller |     controllers/trex_performance_controller.go:291:9: undefined: value
2024-05-21 07:39:12.311570 | controller |     controllers/trex_performance_controller.go:292:40: undefined: value
2024-05-21 07:39:12.311576 | controller |     controllers/trex_performance_controller.go:297:6: mergeWithWorkflow redeclared in this block
2024-05-21 07:39:12.311583 | controller |             controllers/tempest_controller.go:471:6: other declaration of mergeWithWorkflow
2024-05-21 07:39:12.311589 | controller |     controllers/trex_performance_controller.go:317:62: undefined: tempest
2024-05-21 07:39:12.311604 | controller |     controllers/trex_performance_controller.go:21:2: too many errors

I recommend at least running the test-operator with make install run before pushing the change. It looks like copy paste issues from the tempest part that should be easy to fix and some undefined variables.

[1] https://logserver.rdoproject.org/97/97/77d2a159a959cc584d3f36d7305e3202c1e412f0/github-check/openstack-k8s-operators-content-provider/d166321/job-output.txt

Sorry for the awful code from before was just copying around and pushing as an initial stage, should be better now.

softwarefactory-project-zuul · 2024-05-22T15:29:14Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8490d7c928bb479088ee00164e62e445

❌ openstack-k8s-operators-content-provider FAILURE in 8m 25s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2024-05-22T17:10:52Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2b7644fb98304844a52f378e20de8cef

❌ openstack-k8s-operators-content-provider FAILURE in 8m 30s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

api/v1beta1/trex_performance_types.go

controllers/trex_performance_controller.go

main.go

pkg/trexperf/volumes.go

api/v1beta1/trex_performance_types.go

softwarefactory-project-zuul · 2024-05-27T15:23:13Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/39102cf33a5c451c9cb5db3c1dffd79c

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 38m 37s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 11m 44s

softwarefactory-project-zuul · 2024-06-30T15:16:13Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/test-operator for 97,2878c5df14e428813bdabba3405f9af7b86921bc

softwarefactory-project-zuul · 2024-06-30T18:51:50Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d29eadb208d441388b0671b25c1e907f

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 01s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 09m 12s

softwarefactory-project-zuul · 2024-07-01T15:37:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/77ea3d1e8bf9469e8c7180c65aca70e0

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 28s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 09m 02s

softwarefactory-project-zuul · 2024-07-02T13:22:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/028f82349efd4db6859f6ed9290ede33

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 19m 21s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 10m 00s

softwarefactory-project-zuul · 2024-07-02T20:25:08Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5465794a9b27491daef6dc19682d7ff5

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 21s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 09m 18s

lpiwowar · 2024-07-03T07:27:40Z

config/crd/patches/webhook_in_ansibleTests.yaml

+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  name: ansibleTest.test.openstack.org


@eshulman2 I think we have to go through the occurrences of the ansibleTest in the PR. And think whether it should be capitalized or not. As an example you can take a look at HorizonTest CR. You can see that for example here [1] the name for HorionTests CR is not capitalized.

Also, checking whether the test-operator works from locally build test-operator-index would be in this case a good idea I think [2] (question #7).

[1]

test-operator/config/crd/patches/webhook_in_horizontests.yaml

Line 5 in b68150c

name: horizontests.test.openstack.org

[2] https://openstack-k8s-operators.github.io/test-operator/FAQ.html

In this PR [1] we introduce AnsibleTest CR. This patch extends the test-operator so that it can be used to execute tests using the newly introduced CR. [1] openstack-k8s-operators/test-operator#97

This addition should be flexible enough to run ansible playbooks for testing popuses. it is dependent on this patch openstack-k8s-operators/tcib#182

lpiwowar

LGTM! 👍
I think this is a solid foundation for the AnsibleTest CR. We can always address any minor potential issues down the road.

In this PR [1] we introduce AnsibleTest CR. This patch extends the test-operator so that it can be used to execute tests using the newly introduced CR. [1] openstack-k8s-operators/test-operator#97

lpiwowar added the Work In Progress label May 21, 2024

eshulman2 force-pushed the NFV-performance branch from 77d2a15 to be7bba3 Compare May 21, 2024 12:49

eshulman2 force-pushed the NFV-performance branch from be7bba3 to 52bce07 Compare May 22, 2024 10:54

eshulman2 force-pushed the NFV-performance branch from 52bce07 to b220eb0 Compare May 22, 2024 11:13

eshulman2 force-pushed the NFV-performance branch from b220eb0 to f07cbf0 Compare May 22, 2024 15:17

eshulman2 force-pushed the NFV-performance branch 2 times, most recently from 5dd109a to 4e37f5b Compare May 22, 2024 16:07

eshulman2 force-pushed the NFV-performance branch from 4e37f5b to b0a8506 Compare May 23, 2024 10:28

lpiwowar reviewed May 27, 2024

View reviewed changes

api/v1beta1/trex_performance_types.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

api/v1beta1/trex_performance_types.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

api/v1beta1/trex_performance_types.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

api/v1beta1/trex_performance_types.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

controllers/trex_performance_controller.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

main.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

pkg/trexperf/volumes.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

pkg/trexperf/volumes.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

pkg/trexperf/volumes.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

pkg/trexperf/volumes.go Outdated Show resolved Hide resolved

lpiwowar reviewed May 27, 2024

View reviewed changes

api/v1beta1/trex_performance_types.go Outdated Show resolved Hide resolved

lpiwowar marked this pull request as draft May 27, 2024 11:37

eshulman2 force-pushed the NFV-performance branch from b0a8506 to b7b4c73 Compare May 27, 2024 11:39

eshulman2 force-pushed the NFV-performance branch from 2878c5d to cd1f328 Compare June 30, 2024 15:33

eshulman2 force-pushed the NFV-performance branch 2 times, most recently from 45b958a to 3e04b6c Compare July 1, 2024 12:04

eshulman2 changed the title ~~Added controller for running trex performance~~ Added controller for running ansible playbooks Jul 1, 2024

eshulman2 requested a review from lpiwowar July 2, 2024 07:07

eshulman2 force-pushed the NFV-performance branch from 5b77e4f to 1e587ec Compare July 2, 2024 10:01

eshulman2 force-pushed the NFV-performance branch from 1e587ec to 2692b58 Compare July 2, 2024 16:49

lpiwowar reviewed Jul 3, 2024

View reviewed changes

eshulman2 force-pushed the NFV-performance branch from 2692b58 to 7d446ec Compare July 3, 2024 10:15

lpiwowar mentioned this pull request Jul 3, 2024

[test-operator] Introduce AnsibleTest CR openstack-k8s-operators/ci-framework#2017

Merged

4 tasks

eshulman2 force-pushed the NFV-performance branch 2 times, most recently from 5a3b5ce to 5704597 Compare July 3, 2024 12:54

Added controller for running ansible playbooks

d18f11a

This addition should be flexible enough to run ansible playbooks for testing popuses. it is dependent on this patch openstack-k8s-operators/tcib#182

eshulman2 force-pushed the NFV-performance branch from 5704597 to d18f11a Compare July 3, 2024 12:56

Merge branch 'openstack-k8s-operators:main' into NFV-performance

3523216

lpiwowar self-requested a review July 3, 2024 17:46

lpiwowar approved these changes Jul 3, 2024

View reviewed changes

lpiwowar merged commit 2173e83 into openstack-k8s-operators:main Jul 3, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added controller for running ansible playbooks #97

Added controller for running ansible playbooks #97

eshulman2 commented May 21, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented May 21, 2024

lpiwowar commented May 21, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented May 21, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

eshulman2 commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 27, 2024

softwarefactory-project-zuul bot commented Jun 30, 2024

softwarefactory-project-zuul bot commented Jun 30, 2024

softwarefactory-project-zuul bot commented Jul 1, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

lpiwowar Jul 3, 2024

lpiwowar left a comment

Added controller for running ansible playbooks #97

Added controller for running ansible playbooks #97

Conversation

eshulman2 commented May 21, 2024 • edited Loading

softwarefactory-project-zuul bot commented May 21, 2024

lpiwowar commented May 21, 2024 • edited Loading

softwarefactory-project-zuul bot commented May 21, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

eshulman2 commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 22, 2024

softwarefactory-project-zuul bot commented May 27, 2024

softwarefactory-project-zuul bot commented Jun 30, 2024

softwarefactory-project-zuul bot commented Jun 30, 2024

softwarefactory-project-zuul bot commented Jul 1, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

lpiwowar Jul 3, 2024

Choose a reason for hiding this comment

lpiwowar left a comment

Choose a reason for hiding this comment

eshulman2 commented May 21, 2024 •

edited

Loading

lpiwowar commented May 21, 2024 •

edited

Loading