Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation #9

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Documentation #9

merged 2 commits into from
Oct 11, 2023

Conversation

kopecmartin
Copy link
Collaborator

  • Init documentation
  • Change documentation theme

@kopecmartin
Change documentation theme
c2ffef7 
Change the theme to material theme
@kopecmartin kopecmartin temporarily deployed to github-pages October 9, 2023 09:39 — with GitHub Actions Inactive
@kopecmartin kopecmartin requested a review from afazekas October 9, 2023 09:50
@kopecmartin kopecmartin temporarily deployed to github-pages October 9, 2023 12:27 — with GitHub Actions Inactive
lpiwowar
lpiwowar reviewed Oct 10, 2023
View reviewed changes
docs/source/guide.rst Outdated Show resolved Hide resolved
lpiwowar
lpiwowar reviewed Oct 10, 2023
View reviewed changes
docs/source/tempest_pod.rst
.. code-block:: bash

oc apply -f tempest-config.yaml
oc apply -f tempest-deployment.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation: Isn't weird that the tempest-worker pod finishes and then it is started again because openshift detects the end of the script as a Crash?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really? does it detect the end of the script as a fail? .. that is a bug then, let's track it separately

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce now. Previously the pod was oscillating between CrashLoopBackOff <-> Running. Now when I try to reproduce it, the pod status keeps changing between Completed <-> Running. I will keep an eye on this.

@lpiwowar
Copy link
Collaborator

LGTM! I've tried all the steps manually and everything seems to be working. I just added a couple of comments which are not that important.

@kopecmartin
Add documentation
c9d177e 
Document running of tempest via different ways.
@kopecmartin kopecmartin temporarily deployed to github-pages October 11, 2023 12:52 — with GitHub Actions Inactive
@lpiwowar
Copy link
Collaborator

LGTM! 👍

@kopecmartin kopecmartin merged commit d90f57f into main Oct 11, 2023
8 checks passed
@kopecmartin kopecmartin deleted the docs branch December 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpiwowar lpiwowar lpiwowar left review comments

@afazekas afazekas Awaiting requested review from afazekas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kopecmartin @lpiwowar