[OSPRH-11191] Remove dereference for nil pointer

This patch fixes the issue when ExtraConfigmapsMounts is empty. Dereferencing a nil pointer leads to a panic. We now first check whether the pointer is nil and then move to dereferencing it.
openstack-k8s-operators · Nov 13, 2024 · 3e2acc2 · 3e2acc2
1 parent 28d0922
commit 3e2acc2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/ansibletest/volumes.go b/pkg/ansibletest/volumes.go
@@ -106,7 +106,7 @@ func GetVolumes(
 		volumes = append(volumes, extraVol)
 	}
 
-	if len(instance.Spec.Workflow) > 0 && *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
+	if len(instance.Spec.Workflow) > 0 && instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
 		for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {
 			extraWorkflowVol := corev1.Volume{
 				Name: vol.Name,
@@ -204,7 +204,7 @@ func GetVolumeMounts(mountCerts bool, instance *testv1beta1.AnsibleTest, externa
 		volumeMounts = append(volumeMounts, extraConfigmapsMounts)
 	}
 
-	if len(instance.Spec.Workflow) > 0 && *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
+	if len(instance.Spec.Workflow) > 0 && instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
 		for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {
 
 			extraConfigmapsMounts := corev1.VolumeMount{