Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update structured logging #94

Conversation

pinikomarov
Copy link
Contributor

@pinikomarov pinikomarov commented Oct 17, 2023

This automatically adds additional fields like reconcile_id etc.. from the controller context.

before :

2023-09-16T23:17:59.334Z INFO Starting Controller {"controller": "placementapi", "controllerGroup": "placement.openstack.org", "controllerKind": "PlacementAPI"}

after:

2023-09-16T23:15:42.270Z INFO Controllers.PlacementAPI Reconciling Service update {" controller": "placementapi", "controllerGroup": "placement.openstack.org", "controllerKind": "PlacementAPI", "PlacementAPI": {"name":"placement","namespace":"openstack"}, "namespace": "openstack", "name": "placement", "reconcileID": "74348223-8529-4fec-aeab-7e2e4e050683"}

*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

Hi @pinikomarov. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pinikomarov pinikomarov mentioned this pull request Oct 17, 2023
Closed
@gibizer
Copy link
Collaborator

gibizer commented Oct 17, 2023

/ok-to-test

@pinikomarov pinikomarov marked this pull request as ready for review October 18, 2023 19:54
@openshift-ci openshift-ci bot requested review from dprince and kk7ds October 18, 2023 19:56
@pinikomarov
Copy link
Contributor Author

So are we good here ?

Structured logging
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, pinikomarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants