[make][pre-commit]Check CRD schema to avoid update issues #271
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdando
reviewed
Nov 26, 2024
|
lgtm |
gibizer
requested changes
Nov 28, 2024
The new crd-schema-check make target compares the CRD schema of the patch with the schema on the tip of main and report errors on non backward compatible changes. This make target now also run in pre-commit both locally and in CI. This make target uses https://github.com/openshift/crd-schema-checker to do the actual checking. Related: OSPRH-11833
mrkisaolamb
force-pushed
the
crd-schema-checker
branch
from
9e8fdf4 to
a8df309
Compare
bogdando
reviewed
Nov 28, 2024
| @@ -376,3 +376,11 @@ scale-down-placement-controller-csv: | |||
| if [ "$(has_webhooks)" != "null" ]; then \ | |||
| oc patch csv -n $(OPERATOR_NAMESPACE) placement-operator.v0.0.1 --type json -p='[{"op": "remove", "path": "/spec/webhookdefinitions"}]'; \ | |||
| fi | |||
|
|
|||
| CRD_SCHEMA_CHECKER_VERSION ?= release-4.16 | |||
| BRANCH=main | |||
There was a problem hiding this comment.
good to have it for main as of now, but we should also cover cherry picks to fr branches
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 77c84ef
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new crd-schema-check make target compares the CRD schema of the patch with the schema on the tip of main and report errors on non backward compatible changes.
This make target now also run in pre-commit both locally and in CI.
This make target uses https://github.com/openshift/crd-schema-checker to do the actual checking.
Related: OSPRH-11833