Disable HTTP2 in webhooks #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
reviewed
Nov 2, 2023
api/go.mod
Outdated
| @@ -67,3 +67,6 @@ require ( | |||
| // mschuppert: map to latest commit from release-4.13 tag | |||
| // must consistent within modules and service operators | |||
| replace github.com/openshift/api => github.com/openshift/api v0.0.0-20230414143018-3367bc7e6ac7 //allow-merging | |||
|
|
|||
| // Bump golang.org/x/net to avoid Rapid Reset CVE | |||
| replace golang.org/x/net => golang.org/x/net v0.17.0 //allow-merging | |||
There was a problem hiding this comment.
L44 already sets x/net to 0.17 so I think we don't need the replace here
go.mod
Outdated
| @@ -85,6 +85,9 @@ require ( | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| // Bump golang.org/x/net to avoid Rapid Reset CVE | |||
| replace golang.org/x/net => golang.org/x/net v0.17.0 //allow-merging | |||
There was a problem hiding this comment.
I think we don't need the explicit replace
Jira: OSPRH-468
dprince
force-pushed
the
rapid_reset_cve
branch
from
c5bd1b9 to
767a6d7
Compare
gibizer
approved these changes
Nov 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 482a242
into
openstack-k8s-operators:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumps golang.org/x/net to v0.17.0
Jira: OSPRH-468