Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart ovn-controller gracefully on PreStop #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Oct 23, 2024

Otherwise, it will clean up chassis and other relevant records and cause unnecessary router failovers.

--

This is not a complete solution: the operator will have to indicate to ovn-controller when it's actually ok to clean the chassis records up, with the file created in the container. (Note: I am not sure this is the best way to reflect this request into the pod. Perhaps the pod should instead talk to k8s where this information could be exposed. Another alternative is storing this information somewhere in OVSDB - maybe ovn-controller could even be expanded to read the flag from there and do the right thing?)

Related-Issue: OSPRH-10821

@openshift-ci openshift-ci bot requested review from karelyatin and stuggi October 23, 2024 20:28
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@booxter
Copy link
Contributor Author

booxter commented Oct 23, 2024

/retest-required

@karelyatin
Copy link
Contributor

/test ovn-operator-build-deploy-kuttl

Otherwise, it will clean up chassis and other relevant records and cause
unnecessary router failovers.

Related-Issue: OSPRH-10821
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

@booxter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ovn-operator-build-deploy-kuttl 53f441f link true /test ovn-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants