Dedupe services to be deployed for nodeset #881
Conversation
rabi
force-pushed
the
dedeup
branch
2 times, most recently
from
6ced53b to
b7d60d1
Compare
|
Marking WIP to add functional tests. |
|
/test openstack-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cee782a66b9242aab5c479b2bffeadd2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 35m 11s |
|
Is this something you view as blocker for GA? It was shared in the podified call yesterday that "We should consider ourselves in blockers-only mode at this point". If we intend to proceed with this for GA, it should likely have an associated blocking Jira. |
I think this is a good UX improvement. I was not aware of the decision and also started this before Tuesday's podified call. Are we applying this rule for all PRs as I notice PRs[1] merged yesterday without blocker flags? Having said that, if we think we should not merge this before GA, it can wait. [1] #847 |
we can check with @cmsj, the guidance came from him |
|
|
|
/test openstack-operator-build-deploy-kuttl |
|
The code has +2 from me, even though we can't merge it right away. Couple of things to consider in the meantime.
|
Why is that (as discussed yesterday we're not in blocker only mode yet and this is an UX improvement)? As per documentation is concerned, we need to just document that:
I'll will do a doc only follow-up next week. |
|
This isn't a blocker so I'm putting DNM until we either get the priority or the GA is out. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/83bbe194b89047f88f617ea7b9608d0b ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 34m 40s |
- Multiple Services of same ServiceType/ServiceName in nodeset - Global Services in multiple NodeSets for a deployment Signed-off-by: rabi <[email protected]>
Signed-off-by: rabi <[email protected]>
rabi
force-pushed
the
dedeup
branch
2 times, most recently
from
7f7f47d to
5fc7157
Compare
Signed-off-by: rabi <[email protected]>
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2047 is needed. |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6fddb3b235304558b7bd2cbfd538b25d ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 10m 23s |
|
recheck openstack-k8s-operators/ci-framework#2009 is merged now, let's see if that fixes the docs job |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck dropped the outdated Depends-On from the description |
|
|
|
/test openstack-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit da9a7be
into
openstack-k8s-operators:main
Jira: https://issues.redhat.com/browse/OSPRH-8104