-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Glance with the new storage interface #843
Bump Glance with the new storage interface #843
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a533394efe2a43db8e4dd31d9e9ab161 ❌ openstack-k8s-operators-content-provider FAILURE in 14m 13s |
584d7dc
to
3c4dfcb
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/3e7426c693964c88be528a5562fef354 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 22s |
7276f70
to
f44874b
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/61649eddcfa64571af49356274bddd29 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 33s |
708354f
to
64d3e84
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5de30ad461b7444e8693443c379e7d2d ❌ openstack-k8s-operators-content-provider FAILURE in 11m 55s |
/retest-required |
215b310
to
10751f4
Compare
/test precommit-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
@fao89 do you know what's going on w/ |
@fmount I don't know what is happening, but I checkout this PR, ran make docs and it did change. My best guess is something with the binaries, I would try deleting what you have on openstack-operator/bin and run make docs again to see if it changes the docs for you |
I think it's |
it makes sense, try to replace So there are weird things happening with ruby and bundle: do we enforce a specific version? |
10751f4
to
0ec9f1c
Compare
ok the combination of fedora40 with ruby-v3.3 did the trick, but if I slightly change version(s) (even for the asciidoctor) gem I generate a diff output. |
/test openstack-operator-build-deploy-kuttl |
1 similar comment
/test openstack-operator-build-deploy-kuttl |
We currently provide both StorageClass and StorageRequest that can be propagated to the Glance underlying instances. However, it might be possible that operators use extraMounts to plug a NFS share mapped to /var/lib/glance/os_staging_store. In this case, the API should be updated to not provision any PVC and let the human operator to take care about it using the extraMounts interface. This patch updates the Glance bits to reflect the new behavior introduced in the glance-operator. Signed-off-by: Francesco Pantano <[email protected]>
0ec9f1c
to
5217e8c
Compare
@abays @stuggi @konan-abhi we have green CI here and I'm wondering if we can land this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test openstack-operator-build-deploy-kuttl |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mm rechecking kuttl as it seems failing on Looks like openshift/check-payload#197 will fix the current failure. |
/test openstack-operator-build-deploy-kuttl |
/test openstack-operator-build-deploy-kuttl |
ccb7826
into
openstack-k8s-operators:main
We recently merged [1][2] and the Glance API have been updated to reflect the new storage interface. This patch aligns architectures repo CRs with the new structure. [1] openstack-k8s-operators/glance-operator#554 [2] openstack-k8s-operators/openstack-operator#843 Jira: https://issues.redhat.com/browse/OSPRH-6719 Signed-off-by: Francesco Pantano <[email protected]>
Update glance storageClass propagation We recently merged [1][2] and the Glance API have been updated to reflect the new storage interface. This patch aligns architectures repo CRs with the new structure. [1] openstack-k8s-operators/glance-operator#554 [2] openstack-k8s-operators/openstack-operator#843 Jira: https://issues.redhat.com/browse/OSPRH-6719 Reviewed-by: Andrew Bays <[email protected]>
We currently provide both
StorageClass
andStorageRequest
that can be propagated to theGlance
underlying instances.However, it might be possible that operators use
extraMounts
to plug aNFS
share mapped to/var/lib/glance/os_glance_staging_store
.In this case the
API
should be updated to not provision anyPVC
and let the human operator take care about it via theextraMounts
interface.This patch updates the
Glance
bits to reflect the new behavior introduced in theglance-operator
.Jira: https://issues.redhat.com/browse/OSPRH-6719