Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataplane-operator/api #834

Merged

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Jun 10, 2024

Somehow current pinned ansibleee-operator-bundle image got updated to include edpm-ansible PR[1] and causing issues as it requires dataplane-operator api[2] to also get updated.

[1] openstack-k8s-operators/edpm-ansible#653
[2] openstack-k8s-operators/dataplane-operator#875
Related-Issue: OSPCIX-328

Somehow current pinned ansibleee-operator-bundle image
got updated to include edpm-ansible PR[1] and causing
issues as it requires dataplane-operator api[2] to also
get updated.

[1] openstack-k8s-operators/edpm-ansible#653
[2] openstack-k8s-operators/dataplane-operator#875
Related-Issue: OSPCIX-328
@openshift-ci openshift-ci bot requested review from abays and stuggi June 10, 2024 06:55
@karelyatin
Copy link
Contributor Author

/test functional

Passes locally

@abays
Copy link
Contributor

abays commented Jun 10, 2024

/test functional

Passes locally

If this passed locally and then failed in CI, then it looks like we still haven't fully solved the race condition in one of the OpenStackVersion tests. This [1] seems to have helped, but not completely resolved the situation.

[1] #833

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2359fa9f2916474db03fc149d396fd04

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 48s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 10m 33s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 34m 22s

@abays
Copy link
Contributor

abays commented Jun 10, 2024

recheck

 "++ oc get osdpd/openstack -o 'jsonpath={.status.conditions[0].status}'", "error: You must be logged in to the server (Unauthorized)"

@openshift-merge-bot openshift-merge-bot bot merged commit 8813d7e into openstack-k8s-operators:main Jun 10, 2024
7 checks passed
@karelyatin karelyatin deleted the OSPCIX-328 branch June 10, 2024 13:38
softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Jun 10, 2024
Change tlsCert to tlsCerts

A change was recently made to allow specification of multiple certs in a dataplane service.  We need to update our definitions to get the new definition whenever the new changes land.
See: openstack-k8s-operators/dataplane-operator#875
and openstack-k8s-operators/openstack-operator#834

Reviewed-by: John Fulton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants