Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump kustomize" #709

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Revert "Bump kustomize" #709

merged 1 commit into from
Mar 14, 2024

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Mar 14, 2024

This reverts commit a0eb7c3.

@openshift-ci openshift-ci bot requested review from stuggi and viroel March 14, 2024 17:44
@dprince dprince requested a review from fao89 March 14, 2024 17:44
abays
abays approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@dprince
Copy link
Contributor Author

dprince commented Mar 14, 2024

The reverted commit breaks the openstack-operators CSV in that ENV variables are no longer merged correctly.

@dprince
Revert "Bump kustomize"
d6e0037 
This reverts commit a0eb7c3.

That commit breaks the openstack-operators CSV in that ENV variables
are no longer merged correctly.
@dprince dprince force-pushed the revert_bump_kustomize branch from c78c7d7 to d6e0037 Compare March 14, 2024 17:46
@openshift-ci openshift-ci bot removed the lgtm label Mar 14, 2024
@fao89
Copy link
Contributor

fao89 commented Mar 14, 2024

should I revert it in dataplane-operator also?

@dprince
Copy link
Contributor Author

dprince commented Mar 14, 2024

@fao89 I haven't checked dataplane-operator yet. So long as the bundle still has images set we should be okay. Need to look into why this caused the issue here as well.

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ca0c83625d0b4b338d353d89b97b8d9b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 10m 57s
❌ openstack-operator-tempest-multinode FAILURE in 1h 21m 35s

@abays
Copy link
Contributor

abays commented Mar 14, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 06580bd into openstack-k8s-operators:main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 approved these changes

@abays abays abays approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@viroel viroel Awaiting requested review from viroel

Assignees

@abays abays

@fao89 fao89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprince @fao89 @abays