[tlse] memcached tls setup #704
Conversation
If spec.TLS.PodLevel.Enabled is true, setup memcached for TLS usage. Jira: OSPRH-5283
With the rework of the tls struct the method is not really useful.
stuggi
requested review from
olliewalsh,
dciabrin and
Deydra71
and removed request for
dprince and
abays
pkg/openstack/memcached.go
Outdated
| op, err := controllerutil.CreateOrPatch(ctx, helper.GetClient(), memcached, func() error { | ||
| spec.DeepCopyInto(&memcached.Spec) | ||
|
|
||
| if tlsCert != "" { | ||
| memcached.Spec.TLS.CaBundleSecretName = tls.CABundleSecret |
There was a problem hiding this comment.
should it always set the CA bundle?
There was a problem hiding this comment.
yes probably, although I don't think memcached does any outgoing connection. but its in sync with the other services
There was a problem hiding this comment.
also needs a change here https://github.com/openstack-k8s-operators/infra-operator/blob/main/pkg/memcached/volumes.go#L59 . will do a follow up in infra-op
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7538e1b73162462e9a3069b8dd1e0c6a ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 07m 43s |
|
/test images |
2 similar comments
|
/test images |
|
/test images |
|
/test openstack-operator-build-deploy-kuttl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 58d39d5
into
openstack-k8s-operators:main
If spec.TLS.PodLevel.Enabled is true, setup memcached for TLS usage.
Jira: OSPRH-5283