Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tlse] tls for Horizon #650

Merged

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Feb 1, 2024

Creates certs for horizon k8s service and pods when spec.tls.endpoint.internal.enabled: true

Jira: OSPRH-4392

@olliewalsh olliewalsh requested a review from stuggi February 1, 2024 17:18
@openshift-ci openshift-ci bot requested review from dprince and lewisdenny February 1, 2024 17:18
@openshift-ci openshift-ci bot added the approved label Feb 1, 2024
@olliewalsh
Copy link
Contributor Author

/hold rebase has broken something

@olliewalsh
Copy link
Contributor Author

/retest

Creates certs for horizon k8s service and pods when
spec.tls.endpoint.internal.enabled: true

Jira: OSPRH-4392
@olliewalsh
Copy link
Contributor Author

/remove-hold
issue was cached sessions in horizon, need to clear them when toggling tls

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ae4e9e4 into openstack-k8s-operators:main Feb 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants